This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($timeout.$flush): make $flush follow the timeline #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgalfaso - thanks for this. Can you clarify the commit the message. "Make timeout follow the timeline" is a bit vague and doesn't really explain what you are fixing. I guess from looking at the code, that the problem is that the current implementation doesn't take into account new timeouts that are added "out of order". Is that correct? |
| var count1 = 0, count2 = 0; | ||
| var iterate1 = function() { | ||
| count1++; | ||
| $timeout(iterate1, 100); |
There was a problem hiding this comment.
I guess that we don't need to worry about self-referencing timeouts being left around since they are mocked up anyway?
There was a problem hiding this comment.
This is all mock code, if there is a need to clean this up, please let me know
Fix an issue when flushing a $timeout function and, this function, calls $timeout once again. When this is the case, the new timeout function should be called at the thoerical `now` of when the function was called plus the new period
|
@petebacondarwin Thanks for the comment, updated the commit message and hope that it is now clear |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
This is very vaguely related to #13183. It would be interesting to solve both at once... |
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
May 27, 2016
…lbacks If a $timeout handler calls $timeout itself, this new $timeout should be added to the mock deferred queue with a "now" time based on when the original handler was triggered. Previously it was being added with a now time of when the `$timeout.flush` method was originally called. Closes angular#5420
3 tasks
petebacondarwin
pushed a commit
that referenced
this pull request
May 27, 2016
…lbacks If a $timeout handler calls $timeout itself, this new $timeout should be added to the mock deferred queue with a "now" time based on when the original handler was triggered. Previously it was being added with a now time of when the `$timeout.flush` method was originally called. Closes #5420 Closes #14686
IgorMinar
pushed a commit
that referenced
this pull request
Jun 20, 2016
…lbacks If a $timeout handler calls $timeout itself, this new $timeout should be added to the mock deferred queue with a "now" time based on when the original handler was triggered. Previously it was being added with a now time of when the `$timeout.flush` method was originally called. Closes #5420 Closes #14686
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the mock $timeout.$flush follow the timeline when the function
being calls $timeout