Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

revert(validate-commit-msg): fix incorrect comment #3952

Closed
wants to merge 1 commit into from
Closed

revert(validate-commit-msg): fix incorrect comment #3952

wants to merge 1 commit into from

Conversation

daniellmb
Copy link
Contributor

../../ is needed for the symlink to work

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@petebacondarwin
Copy link
Contributor

This is not correct. If you run ln from the root of the angular repository then it works fine. Were you running it from the git/hooks folder?

@daniellmb
Copy link
Contributor Author

I ran it from the root, it created the link but it was invalid. If I try to open it manually I get this error: The operation can’t be completed because the original item can’t be found.

@petebacondarwin
Copy link
Contributor

@daniellmb - sorry, just realised that I am quite wrong and you are right! Will get this merged in.

@ghost ghost assigned petebacondarwin Oct 21, 2013
petebacondarwin pushed a commit that referenced this pull request Oct 21, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants