Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fixes an issue with parse/eval #2509

Closed
wants to merge 2 commits into from
Closed

Fixes an issue with parse/eval #2509

wants to merge 2 commits into from

Conversation

lgalfaso
Copy link
Contributor

Now, when doing

foo().bar()

::foo is called twice, the first time to get the context and the second one for ::bar to get the underlying object. Then the call to ::bar is called using the second instance as self

This is, in the example above, it would be just as doing

var instance1 = foo();
var instance2 = foo();

instance2.bar.apply(instance1);

This patch fixes this issue

lgalfaso added 2 commits April 24, 2013 13:46
@lgalfaso
test(parse): Test for the parsing not invoking twice to get self
2629f7f 
New test to not call twice a function to get self
@lgalfaso
fix(parse): Fix context access and double function call
0305753 
Fix a context duplication and invocation to a previous context when
doing an access modifier function on the result of a function

Closes angular#2496
@lgalfaso
Copy link
Contributor Author

This is now at trunk with Closes #2496

@lgalfaso lgalfaso closed this Apr 29, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lgalfaso