Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(directive): ng:keypress New directives for binding to keypress eve... #2101

Closed
wants to merge 1 commit into from

Conversation

marknadig
Copy link
Contributor

Original PR included on keyup/down. A number of comments suggested need for keypress.#1035 (comment)

@pkozlowski-opensource
Copy link
Member

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
  • Feature improves existing core functionality
  • API is compatible with existing Angular apis and relevant standards (if applicable)
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required [commit message

@IgorMinar
Copy link
Contributor

lgtm

@pkozlowski-opensource
Copy link
Member

@digger69 I've slightly changed the commit message and landed it as f20646b. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants