Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore(e2e): run tests against Chrome 91 on macOS Catalina #17144

Closed
wants to merge 1 commit into from

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jun 8, 2021

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes

What is the current behavior? (You can also link to an open issue here)

  • e2e is only run against Chrome 81 which is 14 months old on a 2 yo OS (macOS Mojave)

What is the new behavior (if this is a feature change)?

  • e2e is run against Chrome 91 on macOS Catalina

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@Splaktar
Copy link
Member Author

Splaktar commented Jun 8, 2021

Looks like this passed other than some flakes and connection issues with Saucelabs.

@Splaktar
Copy link
Member Author

Splaktar commented Jun 8, 2021

It looks like we don't use the features of Protractor that are broken in Chrome 91 by angular/protractor#5519.

@gkalpak gkalpak closed this in 56b0ee3 Jun 12, 2021
gkalpak pushed a commit that referenced this pull request Jun 12, 2021
AnkushLambdatest pushed a commit to AnkushLambdatest/angular.js that referenced this pull request Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants