This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
WIP fix(ngRequired): always evaluate ngRequired at least once #16815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when ngRequired is initially false the required attribute will now be updated properly. Fixes: #angular#16814
codymikol
changed the title
|
I'll have to review these failing tests tonight, but this does seem to be the root of the problem. |
|
Thanks for the PR @codymikol - I have an alternative here that doesn't need the extra variable, can you check if this looks good to you: #16820? |
|
Yes, this looks good 👍 Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ngRequired is initially false the required attribute will now be
updated properly.
Fixes: ##16814
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
#16814
Currently if the ngRequired starts as a false value the old value and the new value will be the same in the $observe and so ctrl.$validate() will not be called. This is a problem because by default the attr.required is set to true.
What is the new behavior (if this is a feature change)?
Now the ngRequired $observe will always validate on the first mutation.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: