Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat($log): add $log.debug() #1625

Closed
wants to merge 1 commit into from
Closed

feat($log): add $log.debug() #1625

wants to merge 1 commit into from

Conversation

nlaplante
Copy link
Contributor

New debug() method with suppressable output via
$logProvider.debugEnabled()

Closes #1592

New debug() method with suppressable output via
$logProvider.debugEnabled()

Closes #1592
@lanterndev
Copy link
Contributor

Might be worth looking at @Wizek's implementation in https://groups.google.com/forum/#!msg/angular/vgMF3i3Uq2Y/q1fY_iIvkhUJ if you haven't seen it yet?

@Wizek
Copy link

Wizek commented Dec 8, 2012

Hi @nlaplante! Do you miss anything in the implementation @Skivvies linked? If so let me know so I can improve it.
If not, do you think I should send it in as pull request no. 61?

p.s. Thanks @Skivvies for mentioning me. :)

@pkozlowski-opensource
Copy link
Member

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@nlaplante
Copy link
Contributor Author

@pkozlowski-opensource I already signed the CLA a while back. Do you need me to do it again?

@pkozlowski-opensource
Copy link
Member

@nlaplante no, if it is signed there is no need to sign again. Thank you!

@vojtajina
Copy link
Contributor

Thank you @nlaplante, merged as 9e991dd.

@Wizek @Skivvies the implementation from mailing list is nice, but I don't think we want this in the core. You can easily implement it on the top of current $log.

@vojtajina vojtajina closed this Jan 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide $log.debug() with associated on/off switch in the provider
5 participants