Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(injector) Fixes #1452: Provider can't be configured with an array #1601

Closed
wants to merge 3 commits into from
Closed

fix(injector) Fixes #1452: Provider can't be configured with an array #1601

wants to merge 3 commits into from

Conversation

sudhirj
Copy link
Contributor

@sudhirj sudhirj commented Nov 23, 2012

The provider constructor now checks to see if the arguments are an
array, which it then instantiates via the providerInjector.

@sudhirj
Fixes #1452
a7bb624 
The `provider` constructor now checks to see if the arguments are an
array, which it then instantiates via the `providerInjector`.
@sudhirj
Copy link
Contributor Author

sudhirj commented Nov 24, 2012

And sorry about bad commit message :( I've read the guidelines but I forgot to follow them this time. Don't want to change history rewriting it now.

@pkozlowski-opensource
Copy link
Member

@sudhirj I've just merged your PR into my private branch, run the AngularJS build and tested. It seems to be working OK with your fix: http://jsfiddle.net/f6C4b/

Thnx!

Would you mind amending the commit message to follow the guidelines:
git commit --amend -m "[New commit message]"

Also have a look at my comment in the commit. Thnx once again!

@pkozlowski-opensource
Copy link
Member

One more thing: did you sign the CLA?

@sudhirj
Copy link
Contributor Author

sudhirj commented Nov 26, 2012

@pkozlowski-opensource Yes on all three counts. Will change to || and amend the commit message in a while, commuting now.

Signed the CLA before I submitted the last bugfix. Do you guys actually send out T-shirts, btw?

@sudhirj
fix(injector): Call instantiate for functions and arrays. Fixes #1452
7252570 
The `provider` constructor now checks to see if the arguments are an
array, which it then instantiates via the `providerInjector`.
@sudhirj
refactor: moved the isArray and isFunction check together
7d4396d
@sudhirj
Copy link
Contributor Author

sudhirj commented Nov 26, 2012

Closing this and starting over with #1611

@sudhirj sudhirj closed this Nov 26, 2012
@sudhirj sudhirj mentioned this pull request Nov 26, 2012
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudhirj @pkozlowski-opensource