This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
test(TzDate): fix test in Australia #14285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably due to implementation differences in browsers for pre-DST period (see angular#5017 and especially angular#5017 (comment) for context), some `TzDate` tests had different behavior on different Timezones/Regions (e.g. failed in Australia, which started to observe DST in 1971). Since the used year (`1970`) didn't have any particular significance, this commit fixes the issue by using a year that is more consistently handled by browsers (`2000`). Fixes angular#14272
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Mar 21, 2016
Probably due to implementation differences in browsers for pre-DST period (see #5017 and especially #5017 (comment) for context), some `TzDate` tests had different behavior on different Timezones/Regions (e.g. failed in Australia, which started to observe DST in 1971). Since the used year (`1970`) didn't have any particular significance, this commit fixes the issue by using a year that is more consistently handled by browsers (`2000`). Fixes #14272 Closes #14285
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably due to implementation differences in browsers for pre-DST periods (see #5017 and especially #5017 (comment) for context), some
TzDatetests had different behavior on different Timezones/Regions (e.g. failed in Australia, which started to observe DST in 1971).Since the used year (
1970) didn't have any particular significance, this commit fixes the issueby using a year that is more consistently handled by browsers (
2000).Fixes #14272