This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix for #11343 - bindToController for multiple directives #11344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| thisLinkFn.$$destroyBindings = | ||
| for (i in elementControllers) { | ||
| // Initialize bindToController bindings for new/isolate scopes | ||
| var scopeDirective = newIsolateScopeDirective || controllerDirectives[i]; |
There was a problem hiding this comment.
This does not look right - if newIsolateScopeDirective exists, it will just use that N times.
There was a problem hiding this comment.
If you try to combine scope: {} with scope: true on the same element you'll get an error earlier:
Multiple directives [first, second] asking for new/isolated scope on: <div first="{{1+1}}" second="{{2+2}}">
So it's either one iteration for isolated scope, or multiple for scope: true
…pe variables fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #11343