$location.search() returns empty when query params are not preceded by hash #7239

nosideeffects · 2014-04-24T18:33:25Z

www.url.com?query=things
$location.search() === {}

www.url.com#?query=things
$location.search() === {query: "things"}

The text was updated successfully, but these errors were encountered:

caitp · 2014-04-24T22:44:53Z

This is a duplicate of #6198 and #5964 --- we know that this works correctly in html5 mode, but alright, I'll take another stab at fixing this.

Not going to close this since the dupe issues are already closed

nosideeffects · 2014-04-24T23:47:22Z

Thank you kindly!

… mode This fix causes LocationHashbangUrl#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. Closes angular#7239

caitp · 2014-04-25T00:49:12Z

@nosideeffects feel free to try that out and see if it works for you. It took a lot of work to get it doing that without breaking it, so it feels very difficult to make this work right in all cases.

… mode This fix causes LocationHashbangUrl#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. Closes angular#7239

nosideeffects · 2014-04-25T14:45:59Z

It still doesn't appear to work in our app without a preceding hash. I will add preceding hashes in our codebase for now.

Thank you for your extremely quick response and hard work!

caitp · 2014-04-25T14:48:51Z

It only works for hashbang mode (not html5 mode because iirc there was already a fix for html5 mode, but apparently not).

However, there is a test verifying that it works without a hash

nosideeffects · 2014-04-25T15:26:06Z

What if the query params exist on page load? The following fails:

url = new LocationHashbangUrl('http://server/base', '#!');
url.$$parse('http://server/base?a=b');
expect(url.search()).toEqual({
  'a': 'b'
});

caitp · 2014-04-25T15:33:20Z

That's because you aren't calling $$rewrite --- but $$rewrite always gets called.

nosideeffects · 2014-04-25T15:57:47Z

Then I am confused by the behavior I am seeing.

$location.absUrl() = "http://local.site.com:8080/login?param=thing"
$location.host() = "local.site.com"
$location.port() = 8080
$location.search() = {}
$location.path() = "" 
$location.hash() = ""

caitp · 2014-04-25T16:07:32Z

There's a test case verifying that it works, you might be using the version of the patch from last night before that was added.

Or you might be using html5Mode. Provide a reproduction so I can see for myself

nosideeffects · 2014-04-25T16:11:45Z

What I am saying is that I am currently using your patched build in our app, which I downloaded a little over an hour ago.

The tests pass, but the $location service still doesn't behave as I would expect.

caitp · 2014-04-25T16:13:04Z

I understand what you're saying, what I'm saying is, post a reproduction

caitp · 2014-04-25T16:31:28Z

I've reproduced it myself, and I see what you're saying. It's because stripHash() is returning too much of the initial url. Not sure why that works in tests then... I'll fix that

… mode This fix causes LocationHashbangUrl#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. Closes angular#7239

caitp · 2014-04-25T16:52:37Z

Okay, fixed

… mode This fix causes LocationHashbangUrl#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. Closes angular#7239

… mode This fix causes LocationHashbangUrl#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. BREAKING CHANGE Previously, LocationHashbangUrl would keep query parameters from the initial URL preceeding a hash symbol as part of the application base url. This is no longer the case, as it is desirable to parse these as part of the search query. To migrate, one should create special urls rather than relying on query string, for instance, if a base url was previously "http://server.com/base?ie=true", it would be adviseable to instead use "http://server.com/base/ie" as the base url. Closes #7239

nosideeffects · 2014-04-25T17:17:40Z

Hurray! Thank you so much!

IgorMinar · 2014-05-01T21:14:09Z

Please take a look at this commit: 3d6dff4

We reverted a similar change in the past because of regressions and overall mismatch with the original design of the $location service.

I realized that this change should however be accepted for the LocationHashbangInHtml5Url mode.

jimthedev · 2014-05-02T16:00:21Z

For those having this problem and needing a workaround now. You can use this to get the querystring parameter 'a':

var parseLocation = function(location) {
    var pairs = location.substring(1).split("&");
    var obj = {};
    var pair;
    var i;

    for ( i in pairs ) {
      if ( pairs[i] === "" ) continue;

      pair = pairs[i].split("=");
      obj[ decodeURIComponent( pair[0] ) ] = decodeURIComponent( pair[1] );
    }

    return obj;
  };

  parseLocation(window.location.search)['a']

…5mlMode This fix causes LocationHashbangInHtml5Url#$$rewrite() to move a pre-hash query string to after the hash. This, in turn, causes urlResolve() to correctly parse the query string, and report the correct dictionary. BREAKING CHANGE Previously, LocationHashbangInHtml5Url would keep query parameters from the initial URL preceeding a hash symbol as part of the application base url. This is no longer the case, as it is desirable to parse these as part of the search query. To migrate, one should create special urls rather than relying on query string, for instance, if a base url was previously "http://server.com/base?ie=true", it would be adviseable to instead use "http://server.com/base/ie" as the base url. Closes angular#7239

caitp · 2014-05-02T21:09:21Z

sorry about the commit spam ^-^

jimthedev · 2014-10-03T13:26:44Z

Thank you!

amitport · 2014-10-24T14:59:34Z

this still happens in angular 1.3

www.url.com?query=things
$location.search() === {}

albertpeiro · 2014-11-25T22:57:14Z

Has this gone into 1.3? If not should we expect it? When?
Thank you!

temp3l · 2014-11-27T20:32:46Z

still happens in 1.3.4 (html5mode)

ryepup · 2015-01-02T18:32:08Z

still happens in 1.3.5 (html5mode)

seiyria · 2015-01-06T15:19:05Z

This seems to work in 1.3.8 with html5mode.

mstrutt · 2015-02-25T13:09:32Z

for me, still happens in 1.3.14 (html5mode)

ams10961 · 2015-03-19T06:26:23Z

The twitter Oauth call-back inserts a token and verifier in the URL before calling, so

www.url.com/index.html#/callback

becomes

www.url.com/index.html?token=abc&verifier=xyz#/callback

What I'd like is:

$location.search() === {token: "abc", verifier:"xyz"}

what I get is

$location.search() === {}

I assume this is the same problem.

griffinqiu · 2015-05-19T07:42:03Z

still has the issue in 1.3.15

+10086

prettycode · 2015-06-23T17:26:27Z

+1 still have issue in 1.3.16

When $location.absUrl() is http://localhost:49215/home/Login/?ReturnUrl=%2fvnext#/, and the HTML page has <base href="/" />, $location.search() returns an empty object.

Ozkee · 2015-10-27T13:41:58Z

for workaround add configuration for module

.config(($locationProvider) ->
$locationProvider.html5Mode({
enabled: true,
requireBase: false
})
)

emersonthis · 2015-10-27T14:02:17Z

I'm still having this problem in v1.4.7. @reg1sek 's workaround worked for me.
CORRECTION: I spoke too soon. The workaround makes $location.search() work for me, but prevents all my <a> links from working because html5Mode rewrites them.

trickpattyFH20 · 2015-10-27T18:03:06Z

@emersonthis http://stackoverflow.com/questions/16837704/angularjs-normal-links-with-html5mode

caitp self-assigned this Apr 24, 2014

caitp added this to the 1.3.0 milestone Apr 24, 2014

caitp added component: $location labels Apr 24, 2014

caitp mentioned this issue Apr 25, 2014

fix($location): parse query parameters which precede hash in hashbang mode #7245

Closed

jeme mentioned this issue Jun 2, 2014

In v0.6.2 $state.goto() params only reflected in location if a query string is already present dotJEM/angular-routing#104

Closed

btford removed the gh: issue label Aug 20, 2014

markusklooth mentioned this issue Sep 9, 2014

$location.search() problems lynndylanhurley/ng-token-auth#32

Closed

IgorMinar modified the milestones: 1.3.0-rc.5, 1.3.0 Oct 2, 2014

caitp closed this as completed Oct 2, 2014

thoop mentioned this issue May 25, 2015

Angular search parameters ignored, converted to normal query params prerender/prerender#197

Closed

tsteur mentioned this issue Jul 31, 2015

Hash in Piwik frontend URLs should include ? instead of just / matomo-org/matomo#8462

Closed

aks681 mentioned this issue Dec 31, 2017

Add refresher exploration redirection oppia/oppia#4307

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

$location.search() returns empty when query params are not preceded by hash #7239

$location.search() returns empty when query params are not preceded by hash #7239

nosideeffects commented Apr 24, 2014

caitp commented Apr 24, 2014

nosideeffects commented Apr 24, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

caitp commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

IgorMinar commented May 1, 2014

jimthedev commented May 2, 2014

caitp commented May 2, 2014

jimthedev commented Oct 3, 2014

amitport commented Oct 24, 2014

albertpeiro commented Nov 25, 2014

temp3l commented Nov 27, 2014

ryepup commented Jan 2, 2015

seiyria commented Jan 6, 2015

mstrutt commented Feb 25, 2015

ams10961 commented Mar 19, 2015

griffinqiu commented May 19, 2015

prettycode commented Jun 23, 2015

Ozkee commented Oct 27, 2015

emersonthis commented Oct 27, 2015

trickpattyFH20 commented Oct 27, 2015

$location.search() returns empty when query params are not preceded by hash #7239

$location.search() returns empty when query params are not preceded by hash #7239

Comments

nosideeffects commented Apr 24, 2014

caitp commented Apr 24, 2014

nosideeffects commented Apr 24, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

caitp commented Apr 25, 2014

caitp commented Apr 25, 2014

caitp commented Apr 25, 2014

nosideeffects commented Apr 25, 2014

IgorMinar commented May 1, 2014

jimthedev commented May 2, 2014

caitp commented May 2, 2014

jimthedev commented Oct 3, 2014

amitport commented Oct 24, 2014

albertpeiro commented Nov 25, 2014

temp3l commented Nov 27, 2014

ryepup commented Jan 2, 2015

seiyria commented Jan 6, 2015

mstrutt commented Feb 25, 2015

ams10961 commented Mar 19, 2015

griffinqiu commented May 19, 2015

prettycode commented Jun 23, 2015

Ozkee commented Oct 27, 2015

emersonthis commented Oct 27, 2015

trickpattyFH20 commented Oct 27, 2015