Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

version 1.8.1 mutually-supporting (2020-09-30) - Deprecation Notices are not correct! #17088

Closed
3 tasks
korengal opened this issue Oct 11, 2020 · 1 comment
Closed
3 tasks

version 1.8.1 mutually-supporting (2020-09-30) - Deprecation Notices are not correct! #17088

korengal opened this issue Oct 11, 2020 · 1 comment
Assignees
@gkalpak
Labels
component: misc core severity: confusing type: docs

Comments

@korengal
Copy link

I'm submitting a ...

  • regression from 1.7.0
  • security issue
  • issue caused by a new browser version
  • [ X] other

In the new release docs:
Deprecated aHrefSanitizationWhitelist. It is now aHrefSanitizationTrustedUri

When I try changing aHrefSanitizationWhitelist to aHrefSanitizationTrustedUri it I'm getting "TypeError: $compileProvider.aHrefSanitizationTrustedUri is not a function".

For now, aHrefSanitizationWhitelist still works fine.

444444444444444444444444444

AngularJS version: 1.8.1

Thanks.
@mgol mgol mentioned this issue Oct 13, 2020
Merged
10 tasks
@mgol
Copy link
Member

mgol commented Oct 13, 2020

Yeah, the changelog is incorrect. It should say aHrefSanitizationTrustedUrlList & imgSrcSanitizationTrustedUrlList.

Fortunately, at least the docs are correct:

@gkalpak gkalpak self-assigned this Oct 13, 2020
gkalpak added a commit to gkalpak/angular.js that referenced this issue Oct 13, 2020
@gkalpak
docs(*): fix docs on recently deprecated properties/methods
3c64595 
In commits 9679e58..3dd42ce, some properties
and methods names including the terms whitelist/blacklist were
deprecated in favor of new ones not including the terms.

This commit fixes some typos in docs related to these changes and adds
links to the new properties/methods in the changelog for easier access.

Fixes angular#17088
gkalpak added a commit that referenced this issue Oct 14, 2020
@gkalpak
docs(*): fix docs on recently deprecated properties/methods
5e85ef3 
In commits 9679e58..3dd42ce, some properties
and methods names including the terms whitelist/blacklist were
deprecated in favor of new ones not including the terms.

This commit fixes some typos in docs related to these changes and adds
links to the new properties/methods in the changelog for easier access.

Fixes #17088
AnkushLambdatest pushed a commit to AnkushLambdatest/angular.js that referenced this issue Jun 29, 2022
@gkalpak
docs(*): fix docs on recently deprecated properties/methods
0096593 
In commits 9679e58..3dd42ce, some properties
and methods names including the terms whitelist/blacklist were
deprecated in favor of new ones not including the terms.

This commit fixes some typos in docs related to these changes and adds
links to the new properties/methods in the changelog for easier access.

Fixes angular#17088
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkalpak gkalpak

Labels
component: misc core severity: confusing type: docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgol @korengal @gkalpak