Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Docs is using old version of angular-bootstrap with click issues in Firefox #14024

Closed
nlwillia opened this issue Feb 12, 2016 · 3 comments
Closed

Comments

@nlwillia
Copy link

The version of angular-bootstrap used by angularjs.org and the documentation site is unspecified, but clearly older than the current 1.1.2 release since nothing has been committed for two years now.

Why does it matter? Well, anyone using Firefox will have a bad time when trying to open header links in a new tab due to a click dispatch bug that wasn't fixed until angular-bootstrap 1.0.0. Who is really to blame here? Firefox is clearly doing something different than other browsers, but it creates a real usability issue which angular-bootstrap has finally moved to solve. However, Angular needs to update its ui-bootstrap version to pick up the change.

It's very frustrating to middle-click or right-click a link and not be able to open it in a new tab, and this has been a problem for Firefox users of the Angular site for years. Tracking the current ui-bootstrap could break other things, but it shouldn't be allowed to stagnate.

@Narretz
Copy link
Contributor

Narretz commented Feb 14, 2016

Thanks for reporting.
It's indeed odd that we use a custom version of bootstrap-ui for the docs app / angularjs.org. But the bug in question was only filed and fixed in December 2015, and we never got any reports about this until now, so I'm not really sure why you are so upset. Bugs happen.

@Narretz Narretz added this to the Backlog milestone Feb 14, 2016
@Narretz Narretz self-assigned this Feb 14, 2016
@nlwillia
Copy link
Author

I'm not upset, but I understand that updating dependencies isn't always trivial, and now that there's an upstream solution I want to make it clear that there's a use case for it. If it helps, one of my first experiences with angular was thinking "why don't the links on their site work right?" which was a source of friction until I understood that it didn't really have anything to do with angular itself.

Narretz added a commit to Narretz/angular.js that referenced this issue Feb 14, 2016
Narretz added a commit to angular/angularjs.org that referenced this issue Feb 17, 2016
- use cdn for loading angular-bootstrap instead of hosting a copy ourselves
- add uib prefix to popover, modal and tab directives
- migrate custom unsafe html popover directive to uib-popover-html + $sce.trustAsHtml
- updating fixes broken right click in dropdowns in FF, see angular/angular.js#14024
@nlwillia
Copy link
Author

Terrific, thanks!

Narretz added a commit to angular/angularjs.org that referenced this issue Feb 22, 2016
- use cdn for loading angular-bootstrap instead of hosting a copy ourselves
- add uib prefix to popover, modal and tab directives
- migrate custom unsafe html popover directive to uib-popover-html + $sce.trustAsHtml
- updating fixes broken right click in dropdowns in FF, see angular/angular.js#14024
Narretz added a commit to angular/angularjs.org that referenced this issue Feb 22, 2016
- use cdn for loading angular-bootstrap instead of hosting a copy ourselves
- add uib prefix to popover, modal and tab directives
- migrate custom unsafe html popover directive to uib-popover-html + $sce.trustAsHtml
- updating fixes broken right click in dropdowns in FF, see angular/angular.js#14024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants