This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "fix(ngOptions): skip comments when looking for option elements"
This reverts commit 7f3f3dd. The fix only fixed a specific case and exhibited a flawed logic (namely skipping every option if the emptyOption is a comment). See #12190 (comment) Conflicts: test/ng/directive/ngOptionsSpec.js
- Loading branch information
Showing
2 changed files
with
1 addition
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beea571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, the commit message for this commit is now up to par with the Commit Message Conventions