This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix($compile): bind all directive controllers correctly when using `b…
…indToController` Previously only the first directive's controller would be bound correctly. Closes #11343 Closes #11345
- Loading branch information
bd7b217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bit awkward, as it is just a correction in a test ...
bd7b217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the commit message?
I just copied the main commit message as this will get squashed when merging the PR.
bd7b217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you merge it already? For me, it now sits on top of the other three commits as a separate commit, but with just the single change in the test.
bd7b217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah flip. I did squash it but for some reason merged the wrong branch.
bd7b217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so just pretend that this was squashed - it will be pretty obvious in the changelog.
Sorry about that.