Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Commit

Permalink
docs(tutorial/step_6): fix experiment description
Browse files Browse the repository at this point in the history
In the experiments section, it is suggested to add a `-` symbol to
`<option value="age">Oldest</option>`. This change is made to reverse
the sort order when selecting the `age` option.

However, this change affects the default `$ctrl.orderProp` that we had
set in `phone-list.component.js`. After making the change, our default
when refreshing the page is "Sort by: [blank]".

This commit adds some additional documentation to clarify that this
behavior makes sense and that the reader should try and fix this within
`phone-list.component.js`.

Closes #16781
  • Loading branch information
ravefalcon92 authored and gkalpak committed Dec 5, 2018
1 parent 6926223 commit 838dd12
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/content/tutorial/step_06.ngdoc
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ You can now rerun `npm run protractor` to see the tests run.

* Reverse the sort order by adding a `-` symbol before the sorting value:
`<option value="-age">Oldest</option>`
After making this change, you'll notice that the drop-down list has a blank option selected and does not default to age anymore.
Fix this by updating the `orderProp` value in `phone-list.component.js` to match the new value on the `<option>` element.


## Summary
Expand Down

0 comments on commit 838dd12

Please sign in to comment.