fix($cacheFactory): return undefined when removing non-existent entry

Instead of throwning an exception, remove should return undefined when cache entry to be removed doesn't exist. Closes #1497
angular · Nov 24, 2012 · 1eb9e22 · 1eb9e22
1 parent c0de8fb
commit 1eb9e22
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/ng/cacheFactory.js b/src/ng/cacheFactory.js
@@ -70,6 +70,8 @@ function $CacheFactoryProvider() {
         remove: function(key) {
           var lruEntry = lruHash[key];
 
+          if (!lruEntry) return;
+
           if (lruEntry == freshEnd) freshEnd = lruEntry.p;
           if (lruEntry == staleEnd) staleEnd = lruEntry.n;
           link(lruEntry.n,lruEntry.p);

diff --git a/test/ng/cacheFactorySpec.js b/test/ng/cacheFactorySpec.js
@@ -89,6 +89,11 @@ describe('$cacheFactory', function() {
       }));
 
 
+      it('should return undefined when entry does not exist', inject(function($cacheFactory) {
+        expect(cache.remove('non-existent')).toBeUndefined();
+      }));
+
+
       it('should stringify keys', inject(function($cacheFactory) {
         cache.put('123', 'foo');
         cache.put(123, 'bar');