fix(mobile-ng-click): prevent unwanted opening of the soft keyboard

Ghost clicks are busted but the corresponding form elements are still focused. This means that for example on smartphones the soft keyboard will be opened. This pull request prevents the unwanted opening of the soft keyboard.
angular · Jul 31, 2013 · 0bbd20f · 0bbd20f · damrbaby · Aug 9, 2013
1 parent 3fdbe81
commit 0bbd20f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/ngMobile/directive/ngClick.js b/src/ngMobile/directive/ngClick.js
@@ -135,6 +135,9 @@ ngMobile.directive('ngClick', ['$parse', '$timeout', '$rootElement',
     // If we didn't find an allowable region, bust the click.
     event.stopPropagation();
     event.preventDefault();
+
+    // Blur focused form elements
+    event.target && event.target.blur();
   }
 
 

diff --git a/test/ngMobile/directive/ngClickSpec.js b/test/ngMobile/directive/ngClickSpec.js
@@ -211,7 +211,10 @@ describe('ngClick (mobile)', function() {
       expect($rootScope.count1).toBe(1);
 
       time = 90;
+      // Verify that it is blured so we don't get soft-keyboard
+      element1[0].blur = jasmine.createSpy('blur');
       browserTrigger(element1, 'click', [], 10, 10);
+      expect(element1[0].blur).toHaveBeenCalled();
 
       expect($rootScope.count1).toBe(1);