-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): use webpack 4 #8611
Conversation
53efad1
to
bc9a0bf
Compare
2c9d81a
to
c0280fb
Compare
36509e3
to
cceec43
Compare
5c6aa81
to
30fdc2b
Compare
30fdc2b
to
a0af533
Compare
} : false | ||
}), | ||
// Not yet supported in webpack 4. | ||
// new HtmlWebpackPlugin({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I do not have index.html
in build because of the following code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we're still waiting for plugins to be updated. At the moment this PR is not ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks like we are expecting #816 to be resolved
Superseded by #9459. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Just trying it out for now. Latest version changelog and feedback thread at webpack/webpack#6357.
Webpack slated for 4.0 final in 25th of February (see https://medium.com/webpack/webpack-4-beta-try-it-today-6b1d27d7d7e2).
To-dos:
webpack.debug.ProfilingPlugin()
System.import
usage (see Disable System.import parser plugin by default webpack/webpack#6321)CommonsChunkPlugin
(see Refactor chunk graph webpack/webpack#6341 and https://gist.github.com/sokra/1522d586b8e5c0f5072d7565c2bee693)Blockers:
.add
instead of.push
for compilation dependencies webpack-contrib/copy-webpack-plugin#174 (not an issue with alpha.0)Warnings:
copy-webpack-plugin
Tapable.plugin is deprecated. Use new API on
.hooksinstead
extract-text-webpack-plugin
DeprecationWarning: Chunk.entrypoints: Use Chunk.getEntrypoints()
Chunk.entrypoints: Use Chunk.addEntrypoint/setEntrypoints to modify entrypoints.
Chunk.chunks: Use Chunk.getChunks() instead
Chunk.parents: Use Chunk.getParents() instead
./src/paths-plugin.ts
DeprecationWarning: The callback argument was splitted into resolveContext and callback.
./angular_compiler_plugin.ts
DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
./src/scripts-webpack-plugin.ts
Tapable.plugin is deprecated. Use new API on '.hooks' instead
WARNING in asset size limit
for large bundles/assetsFix #9058
Fix #9069
Fix #9135