Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): use webpack 4 #8611

Closed
wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Nov 23, 2017

Just trying it out for now. Latest version changelog and feedback thread at webpack/webpack#6357.

Webpack slated for 4.0 final in 25th of February (see https://medium.com/webpack/webpack-4-beta-try-it-today-6b1d27d7d7e2).

To-dos:

Blockers:

Warnings:

  • copy-webpack-plugin
    • Tapable.plugin is deprecated. Use new API on .hooks instead
  • extract-text-webpack-plugin
    • DeprecationWarning: Chunk.entrypoints: Use Chunk.getEntrypoints()
    • Chunk.entrypoints: Use Chunk.addEntrypoint/setEntrypoints to modify entrypoints.
    • Chunk.chunks: Use Chunk.getChunks() instead
    • Chunk.parents: Use Chunk.getParents() instead
  • ./src/paths-plugin.ts
    • DeprecationWarning: The callback argument was splitted into resolveContext and callback.
  • ./angular_compiler_plugin.ts
    • DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
  • ./src/scripts-webpack-plugin.ts
    • Tapable.plugin is deprecated. Use new API on '.hooks' instead
  • WARNING in asset size limit for large bundles/assets

Fix #9058
Fix #9069
Fix #9135

} : false
}),
// Not yet supported in webpack 4.
// new HtmlWebpackPlugin({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I do not have index.html in build because of the following code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we're still waiting for plugins to be updated. At the moment this PR is not ready.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks like we are expecting #816 to be resolved

@filipesilva
Copy link
Contributor Author

Superseded by #9459.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants