Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typescript dep #8185

Merged
merged 4 commits into from
Oct 25, 2017
Merged

Conversation

filipesilva
Copy link
Contributor

No description provided.

They aren't being used anymore
@filipesilva filipesilva force-pushed the remove-typescript-dep branch 2 times, most recently from 607087e to cd61e2c Compare October 25, 2017 16:05
@devoto13
Copy link
Contributor

devoto13 commented Oct 25, 2017

Should this also close #5053? Original report seems to be the same/very similar problem. There are lots of discussions on unrelated topics, so maybe it's better to suggest users to open new issues with clear description instead.

Read more comments in the topic. It doesn't seem to be exactly same issue.

@picosam
Copy link

picosam commented Nov 18, 2017

Hello, is it normal that I'm still getting this error message then:

→ npm install
npm WARN @angular/[email protected] requires a peer of typescript@>=2.4.2 <2.5 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

Using @angular/[email protected] and @angular/*@5.0.2...

@filipesilva
Copy link
Contributor Author

@picosam what version of TS are you using?

@picosam
Copy link

picosam commented Dec 7, 2017

@filipesilva So I now after updating I'm getting this:
npm WARN @angular/[email protected] requires a peer of typescript@>=2.4.2 <2.6 but none is installed. You must install peer dependencies yourself.

In my packages.json file I have this: "typescript": "^2.6.2"

But I'm guessing that I should just ignore the warning? I do realise that only Typescript 2.5 is "officially" supported for now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants