Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(barrel): alphabetized barrel exports #749

Merged
merged 1 commit into from
May 28, 2016

Conversation

phillipgreenii
Copy link
Contributor

Fixes #582

@Brocco
Copy link
Contributor

Brocco commented May 13, 2016

Looks good, can you please rebase this on top of master and squash/fixup the commits to a single commit w/ the message:

fix(barrel): alphabetize barrel exports

Once done, will merge, this looks good!

@phillipgreenii
Copy link
Contributor Author

Updated

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

@phillipgreenii
Copy link
Contributor Author

@Brocco ping; i have rebased this, can it be merged?

@Brocco Brocco merged commit 67b577d into angular:master May 28, 2016
@phillipgreenii phillipgreenii deleted the alphabetize-barrel branch May 28, 2016 04:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barrel exports should be alphabetized
3 participants