Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blueprints): add enum blueprint. #726

Merged
merged 1 commit into from
May 13, 2016
Merged

feat(blueprints): add enum blueprint. #726

merged 1 commit into from
May 13, 2016

Conversation

devversion
Copy link
Member

  • Adds a basic blueprint for a typescript enum.

Not sure, whether the test is a good approach.
It would be better to check for a valid enum value, but I didn't do that - because all other blueprints didn't have values inside of a blueprint.

Closes #707

it('should properly exist', () => {
expect(<%= classifiedModuleName %>).toBeTruthy();
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to add a spec file for enums, nothing is executed so there is no logic to test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I just thought, there have to be some tests, as in the other blueprints. But you're right for enums it doesn't make any sense.

@Brocco
Copy link
Contributor

Brocco commented May 13, 2016

Can you also please add an alias of e here this will allow for ng g e foo and fits the consistency of the other blueprints.

Also, please rebase this on top of the latest master.

* Adds a basic blueprint for a typescript enum.

Closes #707
@devversion
Copy link
Member Author

@Brocco Sure. Updated now :)

@Brocco Brocco merged commit eddb354 into angular:master May 13, 2016
@devversion devversion deleted the feat/add-enum-blueprint branch May 13, 2016 15:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: enum blueprint
2 participants