feat(broccoli): add jade render #626

t-fox · 2016-05-04T12:27:30Z

No description provided.

googlebot · 2016-05-04T12:27:31Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

t-fox · 2016-05-04T12:33:47Z

I signed it!

googlebot · 2016-05-04T12:33:51Z

CLAs look good, thanks!

NoNameProvided · 2016-05-04T12:59:52Z

Jade was renamed to pug, the transition is in progress, but I think the word jade should not be used anymore and it should be replaced with pug everywhere.

hansl · 2016-05-04T15:40:56Z

Hi. Thanks @t-fox! Could you add tests? You can base those on the CSS ones. Also, seems like linting was failing. Please fix and rebase :)

gkalpak · 2016-05-05T17:50:32Z

lib/broccoli/angular-broccoli-jade.js

+
+    options = options || {};
+    Plugin.call(this, inputNodes, {
+      cacheInclude: [/\.jade/]


Shouldn't this be /\.jade$/ (with a $ at the end) ?

t-fox · 2016-05-11T12:12:50Z

OK, @hansl. Added test and rebased. ;) It also uses pug instead of jade.

filipesilva · 2016-06-01T14:56:05Z

@t-fox can you add some instructions to the readme regarding how to use this functionality?

filipesilva · 2016-06-01T14:56:21Z

README.md

@@ -220,6 +220,9 @@ To use one just install for example `npm install node-sass` and rename `.css` fi

 The `Angular2App`'s options argument has `sassCompiler`, `lessCompiler`, `stylusCompiler` and `compassCompiler` options that are passed directly to their respective CSS preprocessors.

+### Additional Support
+- pug (pug)


What does this section mean?

t-fox · 2016-06-03T05:09:06Z

@filipesilva I updated readme and rebased

krasevych · 2016-06-03T09:29:56Z

What about generate code with .pug ?
Because generate code with *.html and then rename to *.pug is not good(

t-fox · 2016-06-07T15:01:25Z

@krasevych Isn't it obvious? Nonetheless I updated Readme.

ivanmayes · 2016-06-14T19:10:21Z

+1 for this

caseyhoward · 2016-06-14T20:58:41Z

tests/e2e/e2e_workflow.spec.js

@@ -367,6 +367,39 @@ describe('Basic end-to-end Workflow', function () {
    });
  });

+  it.skip('Installs pug support successfully', function() {


Why is this skipped?

Other tests like sass support are skipped too since 7c0ba39

ShadowManu · 2016-06-24T05:24:31Z

Besides updating, what's missing for the release of this?

ganySA · 2016-07-04T06:00:44Z

Has this been included?

ShadowManu · 2016-07-04T06:22:16Z

It's still marked as a work in progress. I feel I'm still too green to contribute, but I could help out with what's missing, if original contributors can't.

ShadowManu · 2016-07-18T08:27:26Z

@filipesilva can this issue be revived?

filipesilva · 2016-07-27T01:39:39Z

Closed as this PR was made obsolete by #1455.

I appreciate all the hard work that @t-fox put into this, but we couldn't port it into the new webpack build system as is so we decided not to merge once we started working on webpack.

niklas-dahl · 2016-08-30T10:29:28Z

@filipesilva since the webpack branch is merged now, is there a plan to add a pug/jade loader, just like there is already a sass/less/stylus loader?

It would be awesome if we could just write:

@Component({
  selector: 'app-root',
  templateUrl: './app.component.pug',
  styleUrls: ['./app.component.scss']
})

angular-automatic-lock-bot · 2019-09-11T17:41:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak reviewed May 5, 2016
View reviewed changes

t-fox force-pushed the master branch 5 times, most recently from a88b606 to 82233e3 Compare May 11, 2016 11:48

filipesilva reviewed Jun 1, 2016
View reviewed changes

This was referenced Jun 1, 2016

Jade extension #968

Closed

Change from css to less/scss or from html to jade. #40

Closed

filipesilva added the state: WIP label Jun 1, 2016

t-fox force-pushed the master branch from e767b97 to 837f928 Compare June 2, 2016 14:16

aciccarello mentioned this pull request Jun 3, 2016

Add Pug (Jade) support? #996

Closed

caseyhoward reviewed Jun 14, 2016
View reviewed changes

ShadowManu mentioned this pull request Jul 8, 2016

Master branch update t-fox/angular-cli#1

Closed

googlebot added the cla: yes label Jul 8, 2016

t-fox force-pushed the master branch from 38bf181 to c1d0d4b Compare July 13, 2016 07:56

TomFFox added 8 commits July 13, 2016 09:58

feat(broccoli): add jade render

c8a4fd8

style(broccoli/pug): add $, missing semicolon

bced83c

chore(broccoli): rename jade to pug

219858c

fix(broccoli/pug): do not assign return to unused var

1223c84

chore(broccoli/pug): add test for pug render workflow

ec21422

docs(README): pug integration

29c0fd9

test(e2e_workflow): disable flaky tests

e945e41

docs(README): update section for pug integration

29edbce

t-fox force-pushed the master branch from c1d0d4b to 29edbce Compare July 13, 2016 08:04

filipesilva closed this Jul 27, 2016

ShadowManu mentioned this pull request Sep 9, 2016

Jade support in webpack releases #1886

Closed

niklas-dahl mentioned this pull request Dec 2, 2016

initial support for jade/pug templates #2205

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(broccoli): add jade render #626

feat(broccoli): add jade render #626

t-fox commented May 4, 2016

googlebot commented May 4, 2016

t-fox commented May 4, 2016

googlebot commented May 4, 2016

NoNameProvided commented May 4, 2016

hansl commented May 4, 2016

gkalpak May 5, 2016

t-fox commented May 11, 2016

filipesilva commented Jun 1, 2016

filipesilva Jun 1, 2016

t-fox commented Jun 3, 2016

krasevych commented Jun 3, 2016

t-fox commented Jun 7, 2016

ivanmayes commented Jun 14, 2016

caseyhoward Jun 14, 2016

t-fox Jun 16, 2016

ShadowManu commented Jun 24, 2016

ganySA commented Jul 4, 2016

ShadowManu commented Jul 4, 2016

ShadowManu commented Jul 18, 2016

filipesilva commented Jul 27, 2016

niklas-dahl commented Aug 30, 2016

angular-automatic-lock-bot bot commented Sep 11, 2019

feat(broccoli): add jade render #626

feat(broccoli): add jade render #626

Conversation

t-fox commented May 4, 2016

googlebot commented May 4, 2016

t-fox commented May 4, 2016

googlebot commented May 4, 2016

NoNameProvided commented May 4, 2016

hansl commented May 4, 2016

gkalpak May 5, 2016

Choose a reason for hiding this comment

t-fox commented May 11, 2016

filipesilva commented Jun 1, 2016

filipesilva Jun 1, 2016

Choose a reason for hiding this comment

t-fox commented Jun 3, 2016

krasevych commented Jun 3, 2016

t-fox commented Jun 7, 2016

ivanmayes commented Jun 14, 2016

caseyhoward Jun 14, 2016

Choose a reason for hiding this comment

t-fox Jun 16, 2016

Choose a reason for hiding this comment

ShadowManu commented Jun 24, 2016

ganySA commented Jul 4, 2016

ShadowManu commented Jul 4, 2016

ShadowManu commented Jul 18, 2016

filipesilva commented Jul 27, 2016

niklas-dahl commented Aug 30, 2016

angular-automatic-lock-bot bot commented Sep 11, 2019