-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): bump to tslint 4.5.0 #5099
Conversation
dd11751
to
d1d6f53
Compare
We need to discuss internally if we want to include the new flags for new projects, since we're in RC right now. The other option is simply to update the tslint dependency without the new flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cexbrayat We will let the version update in, but the flags will have to go in after 1.0 is fully release. This is because it would change the way people code by adding constraints, and those are forbidden during our RC.
I'll merge this PR in when the new rules are removed. Thanks!
d1d6f53
to
631c53d
Compare
631c53d
to
77fb403
Compare
@hansl Thank you for considering it. The PR now contains only the tslint bump as you requested. If that's OK with you, I'll open a PR with the new rules after 1.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @cexbrayat.
Dismissed @hansl's review since the requested changes were made and he's away. |
@cexbrayat you can open the PR now and I will mark it as post-1.0. |
@filipesilva Ok great: done in #5389 :) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update: the new rules are pushed back after 1.0 release, this PR now only contains the bump to tslint 4.5
Adds a few rules introduced by tslint 4.4 and 4.5
This introduces the new rule
no-import-side-effect
from @mgechev referenced in #3904.I deliberately relaxed the rule to authorize RxJS imports and avoid tons of warnings on existing apps, but I think it's nice to have it in the tslint config, so people who want to add constraints to these imports will learn about this rule and can easily do it.