Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): bump to tslint 4.5.0 #5099

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Feb 28, 2017

Update: the new rules are pushed back after 1.0 release, this PR now only contains the bump to tslint 4.5

Adds a few rules introduced by tslint 4.4 and 4.5

This introduces the new rule no-import-side-effect from @mgechev referenced in #3904.
I deliberately relaxed the rule to authorize RxJS imports and avoid tons of warnings on existing apps, but I think it's nice to have it in the tslint config, so people who want to add constraints to these imports will learn about this rule and can easily do it.

@cexbrayat cexbrayat force-pushed the chore/tslint-bump branch 3 times, most recently from dd11751 to d1d6f53 Compare February 28, 2017 17:12
@hansl
Copy link
Contributor

hansl commented Feb 28, 2017

We need to discuss internally if we want to include the new flags for new projects, since we're in RC right now. The other option is simply to update the tslint dependency without the new flags.

hansl
hansl previously requested changes Feb 28, 2017
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cexbrayat We will let the version update in, but the flags will have to go in after 1.0 is fully release. This is because it would change the way people code by adding constraints, and those are forbidden during our RC.

I'll merge this PR in when the new rules are removed. Thanks!

@cexbrayat cexbrayat force-pushed the chore/tslint-bump branch from d1d6f53 to 631c53d Compare March 1, 2017 07:30
@cexbrayat cexbrayat force-pushed the chore/tslint-bump branch from 631c53d to 77fb403 Compare March 1, 2017 07:31
@cexbrayat
Copy link
Member Author

@hansl Thank you for considering it. The PR now contains only the tslint bump as you requested.

If that's OK with you, I'll open a PR with the new rules after 1.0 release.

@cexbrayat cexbrayat changed the title chore(lint): bump to tslint 4.5.0 and add a few new rules chore(lint): bump to tslint 4.5.0 Mar 1, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cexbrayat.

@filipesilva
Copy link
Contributor

Dismissed @hansl's review since the requested changes were made and he's away.

@filipesilva filipesilva dismissed hansl’s stale review March 8, 2017 22:38

Changes are made, and user is away.

@filipesilva
Copy link
Contributor

@cexbrayat you can open the PR now and I will mark it as post-1.0.

@cexbrayat
Copy link
Member Author

@filipesilva Ok great: done in #5389 :)

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants