Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore tsc output for tsconfig.spec.json #5062

Closed
wants to merge 3 commits into from
Closed

ignore tsc output for tsconfig.spec.json #5062

wants to merge 3 commits into from

Conversation

johnpapa
Copy link
Contributor

Added /out-tsc to the .gitignore blueprint. If someone runs tsc -p src/tsconfig.spec.json it outputs to the ../out-tsc folder. These should be ignored.

cc @filipesilva

Added /out-tsc to the `.gitignore` blueprint. If someone runs `tsc -p src/tsconfig.spec.json` it outputs to the `../out-tsc` folder. These should be ignored.
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnpapa
Copy link
Contributor Author

alternatively, make the tsconfig.spec.json point output to dist

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@johnpapa
Copy link
Contributor Author

I agree to the CLA

@Meligy
Copy link
Contributor

Meligy commented Feb 28, 2017

The original behaviour was ../dist/out-tsc, which was cool because we clean dist on build.

Do you want to make it different or keep it as it was origina;ly @filipesilva ?

@filipesilva
Copy link
Contributor

@Meligy yes, it is intentional. If these files would go into dist/, they could get deployed by accident.

@johnpapa johnpapa closed this Mar 4, 2017
@johnpapa johnpapa deleted the patch-3 branch March 4, 2017 03:48
@johnpapa johnpapa mentioned this pull request Mar 4, 2017
filipesilva pushed a commit that referenced this pull request Mar 9, 2017
…to .gitignore

Added /out-tsc to the .gitignore blueprint. If someone runs tsc -p src/tsconfig.spec.json it outputs to the ../out-tsc folder. These should
be ignored.

Also changed
https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json#L13 to ../out-tsc/e2e so that they all match.

cc @filipesilva

fixing due to issue with CLA from #5062

Close #5220
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
…to .gitignore

Added /out-tsc to the .gitignore blueprint. If someone runs tsc -p src/tsconfig.spec.json it outputs to the ../out-tsc folder. These should
be ignored.

Also changed
https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json#L13 to ../out-tsc/e2e so that they all match.

cc @filipesilva

fixing due to issue with CLA from angular#5062

Close angular#5220
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants