-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore tsc output for tsconfig.spec.json #5062
Conversation
Added /out-tsc to the `.gitignore` blueprint. If someone runs `tsc -p src/tsconfig.spec.json` it outputs to the `../out-tsc` folder. These should be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json#L13 to ../out-tsc/e2e
so that they all match?
alternatively, make the |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I agree to the CLA |
The original behaviour was Do you want to make it different or keep it as it was origina;ly @filipesilva ? |
@Meligy yes, it is intentional. If these files would go into |
…to .gitignore Added /out-tsc to the .gitignore blueprint. If someone runs tsc -p src/tsconfig.spec.json it outputs to the ../out-tsc folder. These should be ignored. Also changed https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json#L13 to ../out-tsc/e2e so that they all match. cc @filipesilva fixing due to issue with CLA from #5062 Close #5220
…to .gitignore Added /out-tsc to the .gitignore blueprint. If someone runs tsc -p src/tsconfig.spec.json it outputs to the ../out-tsc folder. These should be ignored. Also changed https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json#L13 to ../out-tsc/e2e so that they all match. cc @filipesilva fixing due to issue with CLA from angular#5062 Close angular#5220
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Added /out-tsc to the
.gitignore
blueprint. If someone runstsc -p src/tsconfig.spec.json
it outputs to the../out-tsc
folder. These should be ignored.cc @filipesilva