fix(Help): fixing the help command aliases #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
suggested changes
Feb 21, 2017
| if (cmd === rawArgs[0]) { | ||
| let commandInput = rawArgs[0]; | ||
| const alias = Command.prototype.aliases && Command.prototype.aliases[0]; | ||
| if (commandInput.length === 1 && commandInput === alias) { |
There was a problem hiding this comment.
Why not go through all aliases? Also, some aliases are not 1 character.
There was a problem hiding this comment.
We don't need to iterate just check alias passed and current command are same. Removed check for length 1.
sumitarora
force-pushed
the
feat-help2
branch
3 times, most recently
from
631d6b9 to
cf082ec
Compare
sumitarora
force-pushed
the
feat-help2
branch
from
cf082ec to
006b7cc
Compare
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did mapping of aliases to commands in help
Fixes: #4802