-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@ngtools/webpack): resolve file name before invalidating cached files #4384
Conversation
…iles Fix WebpackCompilerHost's cache invalidation behavior on Windows systems. Previously, no call to _resolve was made, causing paths with backslashes not to match the file cache.
Thanks! This problem makes a lot of pain to me |
Good stuff! |
LGTM. You're right, this was an oversight and we were missing e2e tests for this. I'll add a test. Thanks! |
@hansl Btw, this caching has made watched builds so much faster. Thanks! |
I'm kinda hoping it's just me, and just this project, but while this fix almost completely resolved #4422, I'm noticing sometimes when I make minor changes (I just changed a variable from 2500 to 2000), it still uses the old has and forces me to stop ng serve and restart. I'm not sure if I should have noted this here or in 4422, but thought this was better? It seems to work the vast majority of the time, but on some small changes (not even all), it still reuses a hash. |
@hansl Any plans to release a next beta? This issue is a showstopper for windows users(( |
@quanterion If you install latest webpack (1.2.8) problem is fixed. If you delete node_modules and redo npm install you'll get that version with current cli release as it pulls in latest (I think) |
@rohitsodhia The behavior I've noticed is that sometimes after running for a long time the build freezes up and doesn't emit new files consistently, especially for small changes on a file I've been editing a lot recently. Is this consistent with your experience? |
@msmorgan I didn't notice any freezing... it always emitted, just not updating the hash. Following the upgrade path resolved the problems for me. |
…iles (angular#4384) Fix WebpackCompilerHost's cache invalidation behavior on Windows systems. Previously, no call to _resolve was made, causing paths with backslashes not to match the file cache. Fixes angular#4422 Fixes angular#4345 Fixes angular#4338
…iles (angular#4384) Fix WebpackCompilerHost's cache invalidation behavior on Windows systems. Previously, no call to _resolve was made, causing paths with backslashes not to match the file cache. Fixes angular#4422 Fixes angular#4345 Fixes angular#4338
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix
WebpackCompilerHost
cache invalidation behavior on Windows systems. Previously,invalidate
made no call to_resolve
, causing paths with backslashes not to match the file cache. This caused a watch build to continuously emit the same result.Fixes #4422
Fixes #4345
Fixes #4338