Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve): allow relevant live-reload options to function #3952

Closed
wants to merge 1 commit into from
Closed

fix(serve): allow relevant live-reload options to function #3952

wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 11, 2017

This provides implementations for the following serve command options:

  • live-reload [boolean; default: true] -- flag to control the browser live reload capability
  • live-reload-client [URL; default: ssl/host/port command options] -- specify the URL that the live reload browser client will use

Closes #3361

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an e2e tests for those flags, as there isn't one right now.

@mgol
Copy link
Member

mgol commented Feb 1, 2017

@clydin Do you think you'll have time to finish this soon? My team needs this PR so I'm happy to help if you want.

@filipesilva
Copy link
Contributor

Merged via #4744

@fabionolasco
Copy link

The "ng serve --live-reload false" is still not working for me. I have Angular CLI 1.0.0-beta.26. Does anybody ever got that to work?

@mgol
Copy link
Member

mgol commented Apr 15, 2017

@fabionolasco Your CLI version is very, very old; update it first to the latest one.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack dev server with Vagrant forwarded port
6 participants