feat(tests): add '--suite' option to 'ng e2e' command #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jupapios
changed the title
jupapios
changed the title
hansl
suggested changes
Dec 16, 2016
| const ui = this.ui; | ||
| let exitCode = 0; | ||
|
|
||
| if (options.suite) { | ||
| commandArgs.push(`--suite=${options.suite}`); |
There was a problem hiding this comment.
You're feeding in concatenated strings from the input, which would remove quotes etc. Could you surround the argument with double quotes?
jupapios
force-pushed
the
e2e-suite-option
branch
from
14dc170 to
4c6bfd8
Compare
|
Superseded by #4527 |
Closed
vikerman
pushed a commit
to vikerman/angular-cli
that referenced
this pull request
Oct 6, 2018
resolves: 807 Override suite in the protractor config. Can send in multiple suite by comma seperated values (ng e2e --suite=suite1.ts, suite2.ts). Issue link github.com/angular/issues/807 github.com/angular/pull/3551
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
ng e2ecommand pass through thesuiteoption to protractor #807ie.
ng e2e --suite=somethingng e2e --suite=somethingA,somethingBI created the
unit(I think it used to exist) folder in which I put the e2e command spec and also moved themodelsunit tests inside it but I'm not sure if that is how we want to add unit tests, maybe we could discuss it.Also, I added the
mock-projectfile from ember-cli, needed to run tests against the commands.