feat(github): support usage of gh-token for deployment from external env #3121
Conversation
davinkevin
force-pushed
the
push-to-github-with-token
branch
5 times, most recently
from
ec73994 to
223d343
Compare
|
I maintain the branch up-to-date since the PR, could you say me if you are interested by this PR or not ? Thanks you |
|
@davinkevin can you add some tests for this? The appropriate file is https://github.com/angular/angular-cli/blob/master/tests/acceptance/github-pages-deploy.spec.js |
|
I've already made it : https://github.com/angular/angular-cli/pull/3121/files#diff-86b4ebf8ce530235f5d984c72660361e I will sync the branch with the current head |
davinkevin
force-pushed
the
push-to-github-with-token
branch
2 times, most recently
from
87e72d7 to
b29126d
Compare
|
Synced with master and test updated You can, @filipesilva review it when you want 😄 Thanks |
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
b29126d to
3f5ea9c
Compare
|
The branch is synced with the master... if you want to integrate it ;) |
| @@ -8,7 +8,7 @@ var glob = require('glob'); | |||
| var path = require('path'); | |||
|
|
|||
| var root = 'tests/{acceptance,models}'; | |||
| var specFiles = glob.sync(root + '/**/*.spec.*'); | |||
| var specFiles = glob.sync(root + '/**/github-pages-deploy.spec.*'); | |||
There was a problem hiding this comment.
Can you remove this? I know why you added it, I do it myself while testing, but for merging it can't be there :D
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
3f5ea9c to
bb81d64
Compare
|
@filipesilva Sorry, I totally forgot to remove it during the last sync with master... 😞 It has been removed and synced again with master ;) |
|
@davinkevin you sure you removed it? I still see it in the PR. |
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
bb81d64 to
d94042c
Compare
|
@filipesilva Sorry (again), I try to do too many things at the same time... I've checked, now, my working tree is now clean and the modification aren't in the "File changed" tab. Thanks for your time ;) |
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
235a48e to
dce7709
Compare
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
dce7709 to
392ce31
Compare
In order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as `--gh-token=XYZ`. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different `--gh-username` from the one used for the checkout.
davinkevin
force-pushed
the
push-to-github-with-token
branch
from
392ce31 to
c94eeba
Compare
|
Synced with head to solve conflicts 😉 |
…rom external env (angular#3121) In order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as `--gh-token=XYZ`. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different `--gh-username` from the one used for the checkout.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as
--gh-token=XYZ. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different--gh-usernamefrom the one used for the checkout.