Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(generate): ensure classes and imports are in lower case #2920

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Oct 28, 2016

Fixes #2833

@hansl
Copy link
Contributor

hansl commented Oct 28, 2016

Please add an e2e that test those changes (all variants of them; both case in componentDir and fileName).

@Brocco
Copy link
Contributor Author

Brocco commented Oct 30, 2016

@hansl e2e test added

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hansl hansl merged commit cabc9dc into angular:master Nov 1, 2016
@Brocco Brocco deleted the path-case-2833 branch December 29, 2016 03:56
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-dev-server not detecting file changes
3 participants