Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): resolve error with extract-i18n builder for libraries #28115

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(@angular/build): resolve error with extract-i18n builder for libraries #28115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/angular/build/src/builders/extract-i18n/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,18 @@ export async function execute(
return { success: false };
}

const { projectType } = (await context.getProjectMetadata(projectName)) as {
projectType?: string;
};
if (projectType !== 'application') {
context.logger.error(
`Tried to extract from ${projectName} with 'projectType' ${projectType}, which is not supported.` +
` The 'extract-i18n' builder can only extract from applications.`,
);

return { success: false };
}

// Check Angular version.
assertCompatibleAngularVersion(context.workspaceRoot);

Expand Down
12 changes: 12 additions & 0 deletions packages/angular_devkit/build_angular/src/builders/extract-i18n/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ export async function execute(
return { success: false };
}

const { projectType } = (await context.getProjectMetadata(projectName)) as {
projectType?: string;
};
if (projectType !== 'application') {
context.logger.error(
`Tried to extract from ${projectName} with 'projectType' ${projectType}, which is not supported.` +
` The 'extract-i18n' builder can only extract from applications.`,
);

return { success: false };
}

// Check Angular version.
assertCompatibleAngularVersion(context.workspaceRoot);

Expand Down