Sass url rebasing correctness improvements #27743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebasing URLs within Sass files, the `url` token will now be more accurately detected by ensuring it is not part of a larger token. This prevents custom Sass functions that happen to have a name the ends with `url` from being incorrectly detected.
Remove escaping of the raw existing values present within a URL when rebasing Sass files. These values are present in input code and should retain their respective errors and behavior as written. The escaping of the prefixed path is retained to prevent parsing errors for the internally injected values.
This was
linked to
issues
May 29, 2024
alan-agius4
approved these changes
May 29, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.