Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): support valid self-closing SVG tags in HTML index file #27703

Merged
merged 2 commits into from
May 23, 2024

Conversation

alan-agius4
Copy link
Collaborator

Prior to this change, the Angular build process incorrectly flagged self-closing SVG tags (e.g., <path />) as invalid HTML. This commit rectifies this issue by explicitly allowing self-closing syntax for SVG elements embedded within the HTML index file.

Closes: #27702

…x file

Prior to this change, the Angular build process incorrectly flagged self-closing SVG tags (e.g., `<path />`) as invalid HTML. This commit rectifies this issue by explicitly allowing self-closing syntax for SVG elements embedded within the HTML index file.

Closes: angular#27702
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 23, 2024
@alan-agius4 alan-agius4 requested a review from clydin May 23, 2024 15:46
@wartab
Copy link

wartab commented May 23, 2024

It seems unlikely that people will actually do this, but MathML also contains some self-closing tags such as mspace. Not sure if that needs to be supported

@alan-agius4
Copy link
Collaborator Author

@wartab, added.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2024
…ndex file

Prior to this change, the Angular build process incorrectly flagged self-closing MathML tags (e.g., `<msqrt />`) as invalid HTML. This commit rectifies this issue by explicitly allowing self-closing syntax for MathML elements embedded within the HTML index file.
@alan-agius4 alan-agius4 merged commit c33629e into angular:main May 23, 2024
30 checks passed
@alan-agius4 alan-agius4 deleted the self-closing branch May 23, 2024 16:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
3 participants