feat(@angular-devkit/build-angular): add deployUrl to application builder
#27114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
add-deploy-url-application-builder
branch
from
6267dd5 to
917c6cc
Compare
alan-agius4
force-pushed
the
add-deploy-url-application-builder
branch
from
917c6cc to
d7123ad
Compare
alan-agius4
added
action: review
dgp1130
reviewed
Feb 21, 2024
There was a problem hiding this comment.
I don't have any objections or strong feelings here. The two questions we should probably answer before merging:
@clydin, how do you feel about undeprecating deployUrl in browser / browser-esbuild for the time being?
Should we give this a more descriptive name for application builder (with deployUrl as an alias to whatever the new name is)? Potential options here would be resourceUrl or publicPath. Maybe something else?
clydin
reviewed
Feb 28, 2024
packages/angular_devkit/build_angular/src/builders/application/tests/options/deploy-url_spec.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser/schema.json
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/application/tests/options/deploy-url_spec.ts
Show resolved
Hide resolved
alan-agius4
force-pushed
the
add-deploy-url-application-builder
branch
from
d7123ad to
e23e161
Compare
alan-agius4
force-pushed
the
add-deploy-url-application-builder
branch
from
e23e161 to
d56f404
Compare
…uilder This commit adds the deployUrl option ot the application builder. Closes angular#26411
alan-agius4
force-pushed
the
add-deploy-url-application-builder
branch
from
d56f404 to
d7dc98f
Compare
clydin
approved these changes
Mar 4, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the deployUrl option ot the application builder.
Closes #26411