fix(@angular-devkit/build-angular): ensure compilation errors propagate to all bundle actions #26358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te to all bundle actions If the TypeScript and/or Angular AOT compiler fails to initialize or emit files due to an error, the shared compilation state between the browser code bundle action and any additional bundle actions (polyfills, server, etc.) will now carry an error flag to ensure that the additional bundle actions bypass file emit. The file emit bypass is necessary in these cases to prevent an unintentional and misleading error about a file not being included in the compilation.
clydin
added
target: patch
alan-agius4
approved these changes
Nov 15, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the TypeScript and/or Angular AOT compiler fails to initialize or emit files due to an error, the shared compilation state between the browser code bundle action and any additional bundle actions (polyfills, server, etc.) will now carry an error flag to ensure that the additional bundle actions bypass file emit. The file emit bypass is necessary in these cases to prevent an unintentional and misleading error about a file not being included in the compilation.