Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): limit concurrent output file writes with application builder #26016

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 11, 2023

When using localization with the application builder for a large amount of locales, the number of files that may need to be written to disk can become large. This may be problematic on certain operating systems depending on the open file process limits. To avoid approaching the limit, the number of concurrent writes is now limited to 64.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 11, 2023
…es with application builder

When using localization with the application builder for a large amount of locales, the number
of files that may need to be written to disk can become large. This may be problematic on certain
operating systems depending on the open file process limits. To avoid approaching the limit, the
number of concurrent writes is now limited to 64.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2023
@alan-agius4 alan-agius4 merged commit 0da87bf into angular:main Oct 12, 2023
29 checks passed
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021
@clydin clydin deleted the esbuild/concurrent-writes branch October 12, 2023 13:57
alan-agius4 added a commit that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports #26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes #26021
alan-agius4 added a commit that referenced this pull request Oct 12, 2023
… writes in browser-esbuild builder

This commit ports #26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes #26021

(cherry picked from commit b2678bb)
SarthakD15 pushed a commit to SarthakD15/angular-cli that referenced this pull request Oct 16, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021

fix(@schematics/angular): change Twitter logo to X
alan-agius4 added a commit to SarthakD15/angular-cli that referenced this pull request Oct 17, 2023
… writes in browser-esbuild builder

This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes angular#26021

fix(@schematics/angular): change Twitter logo to X
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application builder with i18n: An unhandled exception occurred: EMFILE: too many open files,
2 participants