-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/build-angular): limit concurrent output file writes with application builder #26016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Oct 11, 2023
…es with application builder When using localization with the application builder for a large amount of locales, the number of files that may need to be written to disk can become large. This may be problematic on certain operating systems depending on the open file process limits. To avoid approaching the limit, the number of concurrent writes is now limited to 64.
clydin
force-pushed
the
esbuild/concurrent-writes
branch
from
October 11, 2023 19:28
01fc188
to
9841c68
Compare
Closed
1 task
alan-agius4
approved these changes
Oct 12, 2023
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
SarthakD15
pushed a commit
to SarthakD15/angular-cli
that referenced
this pull request
Oct 16, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021 fix(@schematics/angular): change Twitter logo to X
alan-agius4
added a commit
to SarthakD15/angular-cli
that referenced
this pull request
Oct 17, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021 fix(@schematics/angular): change Twitter logo to X
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using localization with the application builder for a large amount of locales, the number of files that may need to be written to disk can become large. This may be problematic on certain operating systems depending on the open file process limits. To avoid approaching the limit, the number of concurrent writes is now limited to 64.