Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): handle FORCE_COLOR when stdout is not instance of WriteStream #21737

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 9, 2021

In some cases, custom implementation of stdout, don't extend WriteStream which causes colors not to be included in the output.

Closes #21732

@google-cla google-cla bot added the cla: yes label Sep 9, 2021
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin September 9, 2021 13:57
packages/angular/cli/utilities/color.ts Outdated Show resolved Hide resolved
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2021
…is not instance of `WriteStream`

In some cases, custom implementation of stdout, don't extend `WriteStream` which causes colors not to be included in the output.

Closes #21732
…f `WriteStream`

In some cases, custom implementation of stdout, don't extend `WriteStream` which causes colors not to be included in the output.

Closes #21732
@filipesilva filipesilva merged commit d3fa202 into angular:master Sep 14, 2021
@alan-agius4 alan-agius4 deleted the colors-force-colors branch September 14, 2021 08:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow forcing colors
3 participants