Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): map dev env to environment.ts #2073

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

filipesilva
Copy link
Contributor

By mapping --env=dev directly to environment.ts we can avoid having an extra file that is never really used.

@hansl
Copy link
Contributor

hansl commented Sep 12, 2016

LGTM!

@radoslavpetranov
Copy link

radoslavpetranov commented Sep 15, 2016

Wasn't the idea of having environment.prod.ts and environment.dev.ts to allow the build script to copy the correct file onto environment.ts which in turn is the file referenced in our code

import { environment } from "../environments/environment"

Am I misunderstanding something? Is there a way to import the correct file (that depends on the env variable specified during the build process) into our code right now?

@hansl
Copy link
Contributor

hansl commented Sep 15, 2016

Yes. Same as before, except now environment is also dev. So in development we don't replace it, while in prod (or others) we replace it with the proper environment.

petebacondarwin added a commit to angular-workshops/angular2-testing that referenced this pull request Sep 19, 2016
OK so after some confused reading I see that this file is no longer needed.
See angular/angular-cli#2073
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants