refactor(@angular-devkit/build-angular): use Node.js promise fs API in service-worker augmentation #20518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
core/cleanup-service-worker
branch
from
eb960b5 to
ec26831
Compare
alan-agius4
reviewed
Apr 14, 2021
packages/angular_devkit/build_angular/src/utils/service-worker.ts
Outdated
Show resolved
Hide resolved
…n service-worker augmentation With the minimum version of Node.js now set to v12, the promise fs API can now be leveraged within the tooling. This change also uses `copyFile` (with copy-on-write where available) to setup the the service worker files as well a streaming APIs to generate service worker hashes. Both of which improves performance and reduces memory usage.
clydin
force-pushed
the
core/cleanup-service-worker
branch
from
ec26831 to
fa18319
Compare
alan-agius4
approved these changes
Apr 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the minimum version of Node.js now set to v12, the promise fs API can now be leveraged within the tooling.
This change also uses
copyFile(with copy-on-write where available) to setup the the service worker files as well a streaming APIs to generate service worker hashes. Both of which improves performance and reduces memory usage.