Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add migration to add typedef tslint rule #18494

Closed
wants to merge 1 commit into from
Closed

feat(@schematics/angular): add migration to add typedef tslint rule #18494

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Collaborator

With this change we add a migration to add the typedef tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes #18465

@alan-agius4 alan-agius4 requested a review from clydin August 10, 2020 11:12
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 10, 2020
@alan-agius4 alan-agius4 added this to the V11-candidates milestone Aug 11, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes #18465
@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin August 27, 2020 06:33
@alan-agius4 alan-agius4 deleted the typedef branch September 30, 2020 07:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: blocked target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different tslint typedef behavior between migration and generation
2 participants