added debug argument to ng test task. #1799

abner · 2016-08-22T10:05:13Z

added debug argument to ng test task. This argument when passed disable instrumentation and coverage, allowing to debug the source code when running tests. Fixes #1798

This change is

…sources is not supported. If you are using the graceful-fs module, please update it to a more recent version. �[2K�[1G�[?25h�[2K�[1G�[?25hYou have to be inside an angular-cli project in order to use the test command.. This argument when passed disable instrumentation and coverage, allowing to debug the source code when running tests

…le instrumentation and coverage, allowing to debug the source code when running tests

…instrumentation and coverage, allowing to debug the source code when running tests

abner · 2016-08-23T00:44:50Z

@filipesilva I added this pull request to solve an issue related to not being able to see application code in debug karma session because of the instrumentation made to report the coverage. Basically i added a debug argument to ng test (ng test debug) which disable coverage and instrumentation parts and this way i could see my application code in chrome developer tool debug.
Could you review this and see if it would be merged.
Thanks in advance!

filipesilva · 2016-08-23T18:37:25Z

Before I review, can I ask you to test in the latest master? We had a problem with sourcemaps that is fixed I believe, and would cause you to see instrumented code.

@TheLarkInn can you have a look at #1798 and tell me if this is the sourcemaps issue?

TheLarkInn · 2016-08-23T22:09:31Z

No this is specifically related to instrumented code in testing mode.

abner · 2016-08-24T09:43:46Z

I reviewed and it still occurs. As @TheLarkInn said it is related to instrumented code.

abner · 2016-09-17T07:46:06Z

hi @TheLarkInn and @filipesilva !
I still need this feature in angular-cli. I updated the pull request with master.
Could you guys check if it would be merged?
Thanks in advance.

filipesilva · 2016-09-22T02:14:40Z

@abner I'm sorry it's taken so long to review this PR. I've bumped the original issue as something that needs to be finished for RC1 and we should get to it soon.

…-cli into add-debug-argument-to-test

abner · 2016-09-22T02:59:19Z

great @filipesilva . I just updated the branch.

filipesilva · 2016-10-03T17:17:49Z

CI is showing a lint error:

/home/travis/build/angular/angular-cli/packages/angular-cli/models/webpack-build-test.js
  9:7  error  'debug' is already defined  no-redeclare

It's minor but I cannot merge it without a green CI.

filipesilva · 2016-10-03T17:31:55Z

packages/angular-cli/commands/test.ts

@@ -5,6 +5,7 @@ import {CliConfig} from '../models/config';
 const NgCliTestCommand = TestCommand.extend({
  availableOptions: [
    { name: 'watch', type: Boolean, default: true, aliases: ['w'] },
+    { name: 'debug', type: Boolean, default: false, aliases: ['d'] },


How is this option being passed into the karma config? I don't think it's being passed in yet.

My suggestion is this: in karma.conf.js add in the debug property to the angularCli options:

angularCli: { config: './angular-cli.json', environment: 'dev', debug: false },

Then you'll need to also change packages/angular-cli/tasks/test.ts to set this to true in the options variable that's being passed into karma.Server.

Make sure it works though, this is the kind of thing I don't know we can really do CI tests without doing really weird stuff.

i actually implemented debug false as default so it doesn't need to be passed. i added an argument to the test command --debug (-d). I think we would add a npm script npm run test:debug which would call ng test --debug

I was tracing back the code and realize you are right. Since we just start karma with all the options that the command receives, the debug property will be there. My bad!

filipesilva · 2016-10-03T17:34:06Z

packages/angular-cli/models/webpack-build-test.js

@@ -66,7 +67,7 @@ const getWebpackTestConfig = function (projectRoot, environment, appConfig) {
        { test: /\.(jpg|png)$/, loader: 'url-loader?limit=128000' },
        { test: /\.html$/, loader: 'raw-loader', exclude: [path.resolve(appRoot, appConfig.index)] }
      ],
-      postLoaders: [
+      postLoaders: debug ? [] : [


In the latest webpack update, the loader configs changed a bit and is now a single rules array.

You're probably going to have to add the sourcemap-istanbul-instrumenter-loader conditionally, but by itself, at the end.

ok @filipesilva . i will update this branch to the latest changes in master and fix the linting issue you mentioned.

filipesilva · 2016-10-03T17:34:21Z

packages/angular-cli/models/webpack-build-test.js


  const appRoot = path.resolve(projectRoot, appConfig.root);
+  var debug = typeof debug !== 'undefined' ?  debug : false;


Linting says this variable is being shadowed.

filipesilva · 2016-10-14T19:35:57Z

@abner we were talking about this PR between the team, and thinking of a somewhat alternative solution.

How about having a --code-coverage (-cc) flag that adds the instrumentation, instead of having a --debug flag to disable it? I don't think users care about code coverage during their normal watch cycle, and it should make things faster as well.

What do you think?

Partially address angular#1980 Close angular#1799

@abner

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

filipesilva · 2016-10-23T13:36:00Z

Heya @abner, I ran with the idea of making code coverage optional, and also made linting optional in #2840.

@abner

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

@abner

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

@abner

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

@abner

Heavily inspired by @abner's work on #1799. Partially address #1980 Close #1799

angular-automatic-lock-bot · 2019-09-10T04:42:33Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

abner added 2 commits August 22, 2016 06:41

added debug argument to ng test task. This argument when passed disab…

fda89ed

…le instrumentation and coverage, allowing to debug the source code when running tests

googlebot added the cla: yes label Aug 22, 2016

abner added 2 commits August 22, 2016 17:41

added debug argument to test task. This argument when passed disable …

58ac230

…instrumentation and coverage, allowing to debug the source code when running tests

fixed debug default value

ad82f9a

abner force-pushed the add-debug-argument-to-test branch from fda89ed to ad82f9a Compare August 22, 2016 20:43

filipesilva added the needs: more info Reporter must clarify the issue label Aug 23, 2016

abner added 3 commits September 17, 2016 04:33

updating the master with upstream

61b4b23

merge with upstream master

67339fd

updates after merge with upstream

d74ce89

Merge branch 'master' into add-debug-argument-to-test

e6378bd

filipesilva added pr_action: review and removed needs: more info Reporter must clarify the issue labels Sep 22, 2016

abner added 3 commits September 21, 2016 23:51

Merge branch 'master' into add-debug-argument-to-test

3d58bdd

merge with master

9295253

Merge branch 'add-debug-argument-to-test' of github.com:abner/angular…

4c073e0

…-cli into add-debug-argument-to-test

abner added 3 commits September 22, 2016 06:17

remove repeated line

327defb

Merge branch 'master' into add-debug-argument-to-test

015b476

Merge branch 'master' into add-debug-argument-to-test

cf5c2be

filipesilva suggested changes Oct 3, 2016

View reviewed changes

filipesilva added the state: WIP label Oct 14, 2016

filipesilva removed the pr_action: review label Oct 14, 2016

filipesilva self-assigned this Oct 14, 2016

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 23, 2016

feat(test): make code coverage and lint optional

bcae9f3

Partially address angular#1980 Close angular#1799

filipesilva mentioned this pull request Oct 23, 2016

feat(test): make code coverage and lint optional #2840

Merged

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 23, 2016

feat(test): make code coverage and lint optional

0f4efb0

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 23, 2016

feat(test): make code coverage and lint optional

70a3e7e

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 23, 2016

feat(test): make code coverage and lint optional

ab069bc

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 23, 2016

feat(test): make code coverage and lint optional

efb5cd7

Heavily inspired by @abner's work on angular#1799. Partially address angular#1980 Close angular#1799

filipesilva closed this in #2840 Oct 24, 2016

filipesilva added a commit that referenced this pull request Oct 24, 2016

feat(test): make code coverage and lint optional (#2840)

8944d04

Heavily inspired by @abner's work on #1799. Partially address #1980 Close #1799

lathonez mentioned this pull request Jan 3, 2017

Source maps are not working lathonez/clicker#203

Closed

lathonez mentioned this pull request Mar 28, 2017

Add Test Coverage ionic-team/ionic-unit-testing-example#12

Open

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added debug argument to ng test task. #1799

added debug argument to ng test task. #1799

abner commented Aug 22, 2016 •

edited

Loading

abner commented Aug 23, 2016

filipesilva commented Aug 23, 2016

TheLarkInn commented Aug 23, 2016

abner commented Aug 24, 2016

abner commented Sep 17, 2016

filipesilva commented Sep 22, 2016

abner commented Sep 22, 2016

filipesilva commented Oct 3, 2016

filipesilva Oct 3, 2016

abner Oct 4, 2016

filipesilva Oct 4, 2016

filipesilva Oct 3, 2016

abner Oct 3, 2016

filipesilva Oct 3, 2016

filipesilva commented Oct 14, 2016

filipesilva commented Oct 23, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019


		const appRoot = path.resolve(projectRoot, appConfig.root);
		var debug = typeof debug !== 'undefined' ? debug : false;

added debug argument to ng test task. #1799

added debug argument to ng test task. #1799

Conversation

abner commented Aug 22, 2016 • edited Loading

abner commented Aug 23, 2016

filipesilva commented Aug 23, 2016

TheLarkInn commented Aug 23, 2016

abner commented Aug 24, 2016

abner commented Sep 17, 2016

filipesilva commented Sep 22, 2016

abner commented Sep 22, 2016

filipesilva commented Oct 3, 2016

filipesilva Oct 3, 2016

Choose a reason for hiding this comment

abner Oct 4, 2016

Choose a reason for hiding this comment

filipesilva Oct 4, 2016

Choose a reason for hiding this comment

filipesilva Oct 3, 2016

Choose a reason for hiding this comment

abner Oct 3, 2016

Choose a reason for hiding this comment

filipesilva Oct 3, 2016

Choose a reason for hiding this comment

filipesilva commented Oct 14, 2016

filipesilva commented Oct 23, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

abner commented Aug 22, 2016 •

edited

Loading