Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several package install fixes (ng add/update) #16880

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Several package install fixes (ng add/update) #16880

merged 3 commits into from
Feb 11, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Feb 7, 2020 •
edited
Loading

Fixes: #16865
Fixes: #16766

@clydin clydin added the target: patch This PR is targeted for the next patch release label Feb 7, 2020
@clydin clydin changed the title Several temporary package install fixes (ng add/update) Several package install fixes (ng add/update) Feb 7, 2020
@clydin clydin requested a review from alan-agius4 February 7, 2020 20:38
alan-agius4
alan-agius4 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 7, 2020
@dgp1130 dgp1130 merged commit f4127b5 into angular:master Feb 11, 2020
@clydin clydin deleted the ng-add-registry branch February 11, 2020 00:13
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 11, 2020

Also merged to 9.0.x patch branch.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng update fails when windows username contains a space ng add --registry not working
4 participants
@clydin @dgp1130 @alan-agius4 @googlebot