fix(@angular-devkit/core): Rename to a non-existing dir

[sacgrover]

Schematics: rename to a non-existing dir fails on sync to disk #16484

[alan-agius4]

@sacgrover thanks for this, see comment above. Also can you kindly add a unit test in https://github.com/angular/angular-cli/blob/dbaa1be12b4897b130a30a34be0a502125e312ae/packages/angular_devkit/core/node/host_spec.ts and also add Fixes #16484 as a commit footer?

[alan-agius4]

The castings here are not correct The to and from here are devkit paths are they are not interchangeable with FS paths, so you need to get the system path first.

So the logic here should look more like;

try {
  const toSystemPath = getSystemPath(to);
  if (!fs.existsSync(path.dirname(toSystemPath)) {
      fs.mkdirSync(path.dirname(toSystemPath), { recursive: true });
  }

  fs.renameSync(getSystemPath(from), toSystemPath);
  obs.next();
  obs.complete();
} catch (err) {
  obs.error(err);
}

[sacgrover]

@alan-agius4 Asked changes done.

[alan-agius4]

Can you please squash the commits? Otherwise looks good. Thanks.

[sacgrover]

Squashing done. @alan-agius4

[alan-agius4]

Thanks LGTM

[sacgrover]

@alan-agius4 when it will be merged? I am asking because I can see lot of new issues and I want to work on them but by mistake I committed in master branch now If I take a branch out of it then it will not be in synced with original and will have the pending merge changes in it.

[dgp1130]

Merged to 9.0.x patch branch as well.

We have a caretaking process which merges ready PRs daily, so merging should always be pretty timely after approval and tests pass. Full docs.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}