fix(@angular/cli): disable update commit creation by default #16105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Nov 7, 2019
Splaktar
reviewed
Nov 8, 2019
| @@ -63,8 +63,8 @@ | |||
| "type": "boolean", | |||
| "default": false | |||
| }, | |||
| "skipCommits": { | |||
| "description": "Do not create source control commits for updates and migrations.", | |||
| "createCommits": { | |||
There was a problem hiding this comment.
I would prefer commitUpdates or commitChanges as I think that is more descriptive since it includes a hint at what is in the commits.
I guess the current version does hint at the fact that it might create more than a single commit.
However, as a user, I feel like 'createCommits' is more vague and will confuse many developers.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16013