feat(@angular-devkit/build-angular): set document locale with i18n #15718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for the contribution. This was something that we were interesting in including for 9.0. An exception can be added for the lint failure via an inline comment. That function will be refactored in the medium-term anyway. The other CI failure is a flake and can be ignored. |
TinyMan
force-pushed
the
build-document-locale
branch
from
ddc1084 to
3803129
Compare
clydin
approved these changes
Oct 2, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using i18n (
i18nLocale), set the document locale inindex.htmlusing the htmllangattribute.Fixes #8102