Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): downlevel with non-loose ECMA compliance #15675

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 25, 2019

This helps to ensure that the ES5 bundles operate consistently with the ES2015+ bundles.

Fixes #15673

@clydin clydin added the target: patch This PR is targeted for the next patch release label Sep 25, 2019
@clydin
Copy link
Member Author

clydin commented Sep 26, 2019

Note to caretaker: Size failure is expected due to an increased size from a more comprehensive downlevel of the application code.

This also only results in a ~2KB difference in compressed (gzip) sizes for the main ES5 bundle of a new application with lazy routing. No differences in ES2015 bundles.

@clydin clydin requested a review from alan-agius4 September 26, 2019 13:31
@clydin clydin force-pushed the strict-ecma branch 2 times, most recently from 51e4eaa to 28fafba Compare September 26, 2019 15:15
…pliance

This ensures that the ES5 bundles operate consistently with the ES2015+ bundles.

Fixes angular#15673
@vikerman vikerman merged commit 941c6af into angular:master Sep 30, 2019
@clydin clydin deleted the strict-ecma branch September 30, 2019 17:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.3.x ES5 build broken for spread operator on set
4 participants