Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/cli): create commits per migration during update #15611

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 17, 2019

No description provided.

@clydin clydin added the target: major This PR is targeted for the next major release label Sep 17, 2019
@clydin clydin requested a review from alan-agius4 September 17, 2019 01:36
@@ -136,6 +136,7 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
const description = schematic.description as typeof schematic.description & {
version?: string;
};
description.version = coerceVersionNumber(description.version) || undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not: redundant || undefined

@mgechev mgechev merged commit ace02f6 into angular:master Sep 17, 2019
@clydin clydin deleted the migration-commits branch September 17, 2019 16:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants