Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): default poll value when not present #15417

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 23, 2019

--poll is a valid command line option (vs. --poll 1000). This however will result in a value of 0 which causes polling to be disabled rather than enabled which is completely non-obvious. This change sets a default value of 500 when the commandline flag is used.

`--poll` is a valid command line option (vs. `--poll 1000`).  This however will result in a value of 0 which causes polling to be disabled rather than enabled.  This change sets a default value of 500 when the commandline flag is used.
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 23, 2019
@clydin clydin requested a review from alan-agius4 August 23, 2019 00:30
@mgechev mgechev merged commit af9a8b7 into angular:master Aug 23, 2019
@clydin clydin deleted the default-poll-option branch August 23, 2019 18:48
@clydin clydin mentioned this pull request Aug 24, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants