fix(@angular/cli): ng-update migrations not running with --migrate-only #14567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Angular CLI version 8, migrations cannot be re-run with the `--migrate-only` flag as there was a recent regression introduced in e406f00#diff-0d0a748fb9a38a7ccde08d9b42e70bce as it now passes a normalized platform path to the `engine.createCollection` call. This breaks as there is incorrect logic within `node-modules-engine-host` that causes the schematic collection to be searched within the `package.json#schematics` entry. This is incorrect as migration schematics specify their migration schematics in a separate schematic collection file which is part of `package.json#ng-update`. Fixes #14565
devversion
force-pushed
the
fix/windows-schematic-resolve-collection
branch
from
1a61fe0
to
6ee0028
Compare
clydin
approved these changes
May 29, 2019
devversion
added
the
P1
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Angular CLI version 8, migrations cannot be re-run with the
--migrate-onlyflag as there was a recent regression introducedin e406f00#diff-0d0a748fb9a38a7ccde08d9b42e70bce as it now passes
a normalized platform path to the
engine.createCollectioncall.This breaks as there is incorrect logic within
node-modules-engine-hostthat causes the schematic collection to besearched within the
package.json#schematicsentry. This is incorrectas migration schematics specify their migration schematics in a separate
schematic collection file which is part of
package.json#ng-update.Fixes #14565